-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.43.2 #5228
Closed
Closed
Release 2.43.2 #5228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lucano Vera <[email protected]>
Pydantic v1 -> Pydantic v2 upgrade Co-authored-by: Adrian Galvan <[email protected]> Co-authored-by: eastandwestwind <[email protected]>
Co-authored-by: Adam Sachs <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides Run #9620
Run Properties:
|
Project |
fides
|
Branch Review |
release-2.43.2
|
Run status |
Passed #9620
|
Run duration | 00m 38s |
Commit |
3410c42851: update changelog for 2.43.2
|
Committer | Adam Sachs |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5228 +/- ##
==========================================
- Coverage 86.56% 86.40% -0.16%
==========================================
Files 362 362
Lines 22741 22763 +22
Branches 3026 3056 +30
==========================================
- Hits 19685 19669 -16
- Misses 2511 2537 +26
- Partials 545 557 +12 ☔ View full report in Codecov by Sentry. |
Kelsey-Ethyca
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.43.2
!2.43.1
was deleted due to the fact that we tried to "republish" it after finding a bug last minute. Republishing does not work with PyPI - it rejects the package, even if the package with the identical version number even if the package was "deleted": https://pypi.org/help/#file-name-reuse2.43.2
instead, which is identical to what2.43.1
shows, but is just "re-labeled" as2.43.2
see #5221 for more information on the original
2.43.1
branch and release process. The below checklist has been copied over from that original PR, since thisrelease-2.43.2
branch is identical to thatrelease-2.43.1
branch.Release Checklist
The release checklist is a manual set of checks done before each release to ensure functionality of the most critical components of the application. Some of these steps are redundant with automated tests, while others are only tested here as part of this check.
This checklist should be copy/pasted into the final pre-release PR, and checked off as you complete each step.
Additionally, there is a robust Release Process page available in Confluence (internal only).
Pre-Release Steps
General
From the release branch, confirm the following:
nox -s quickstart
(verify you can complete the interactive prompts from the command-line)nox -s "fides_env(test)"
(verify the admin UI on localhost:8080, privacy center on localhost:3001, CLI and webserver)Next, run the following checks via the test environment:
API
CLI
Run these from within the test environment shell:
git reset --hard
- Note: This is required for thepull
command to workfides user login
fides push src/fides/data/sample_project/sample_resources/
fides pull src/fides/data/sample_project/sample_resources/
fides evaluate src/fides/data/sample_project/sample_resources/
fides generate dataset db --credentials-id app_postgres test.yml
- Note: Because the filesystem isn't mounted, the new file will only show up within the containerfides scan dataset db --credentials-id app_postgres
Privacy Center
Admin UI
User Permissions
Documentation
Instead, they should be committed on a branch off of
main
and then PR'd and merged intomain
, before being cherry-pickedover to the release branch. This ensures that the CHANGELOG stays consistent between the release branch and
main
.Publishing the release
When publishing the release, be sure to include the following sections in the release description:
## Release Pull Request
section that includes a link back to the release PR (i.e., this one!) for tracking purposes## QA Touch Test Run
section that includes a link to the QATouch test run (QA team should provide this)Post-Release Steps
python3 -m venv 2_12_0_venv
source 2_12_0_venv/bin/activate
pip install ethyca-fides
fides deploy up